feat(oas31): display file upload input when contentMediaType or contentEncoding is present#10412
Merged
feat(oas31): display file upload input when contentMediaType or contentEncoding is present#10412
Conversation
…ntEncoding is present Refs #9278
glowcloud
added
type: enhancement
version: 5.x
specification: 3.1
char0n
reviewed
Apr 11, 2025
char0n
reviewed
Apr 11, 2025
| : schema.contentEncoding | ||
|
|
||
| return ( | ||
| (contentMediaType && typeof contentMediaType === "string") || |
Contributor
There was a problem hiding this comment.
Suggested change
| (contentMediaType && typeof contentMediaType === "string") || | |
| (typeof contentMediaType === "string" && contentMediaType !== "") || |
char0n
reviewed
Apr 11, 2025
|
|
||
| return ( | ||
| (contentMediaType && typeof contentMediaType === "string") || | ||
| (contentEncoding && typeof contentEncoding === "string") |
Contributor
There was a problem hiding this comment.
Suggested change
| (contentEncoding && typeof contentEncoding === "string") | |
| (typeof contentEncoding === "string" && contentEncoding !== "") |
char0n
approved these changes
Apr 11, 2025
Contributor
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
Let's add comment explaining the short-circuit mechanism + explicit non-empty string assertions.
delendik-testops
pushed a commit
to ModiusOpenData/swagger-ui
that referenced
this pull request
Mar 3, 2026
…ntEncoding is present (swagger-api#10412) Refs swagger-api#9278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #9278
Implement layer 3 of #9278 (comment)